https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #9 from Vít Ondruch <vondr...@redhat.com> ---
Oh, you are applying the latest packaging techniques (unpacking the gem via
%setup), very nice :)

However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite fails
entirely, you won't notice. I would rather see the tests disabled one by one or
some explanation at minimum.

Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility with
latest RSpec? Isn't there patch available upstream already?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to