Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=644259 Parag AN(पराग) <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |[email protected] AssignedTo|[email protected] |[email protected] Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <[email protected]> 2010-10-19 05:58:18 EDT --- Few suggestions: 1) as per latest packaging guidelines, if new package is supposed to be built on F13 and above then buildroot tag, %clean section and removal of buildroot in %install can be dropped. See https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag and https://fedoraproject.org/wiki/PackagingGuidelines#.25clean 2) No need of prefix in make install 3) Good if you will add some comment above Requires: about why these explicit requires are needed for this package. 4) Looks BR: pod2man is not needed. See successful koji build without it http://koji.fedoraproject.org/koji/taskinfo?taskID=2542583 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
