--- Comment #1 from Robert-André Mauchin <> ---

 - Not used in Fedora anymore:





 - Use the correct systemd macros:

BuildRequires: systemd

 - the license file must be included with %license, not %doc:

%license COPYING

 - These %attr(644,root,root) %attr(755,root,root) are not needed because they
are already the default value.

 - COPYING contains GNU General Public License v3.0 but your license header
contains GPLv2+. Please use GPLv3 or GPLv3+.

 - Please follow to
add user and group.
   Add Requires(pre): shadow-utils

getent group GROUPNAME >/dev/null || groupadd -r GROUPNAME
getent passwd USERNAME >/dev/null || \
    useradd -r -g GROUPNAME -d HOMEDIR -s /sbin/nologin \
    -c "Useful comment about the purpose of this account" USERNAME
exit 0

 - In %files, for man pages, don't directly link to the gz extension but use a


See for rationale.

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to

Reply via email to