https://bugzilla.redhat.com/show_bug.cgi?id=1268696



--- Comment #10 from Ilya Gradina <ilya.grad...@gmail.com> ---
(In reply to Vít Ondruch from comment #9)
> Oh, you are applying the latest packaging techniques (unpacking the gem via
> %setup), very nice :)
> 
> However, the "rspec -Ilib spec ||:" is too hand-wavy. If the test suite
> fails entirely, you won't notice. I would rather see the tests disabled one
> by one or some explanation at minimum.
> 
> Why are the Guard::RSpecFormatter tests failing anyway? It seems the time is
> now formatted differently. Is it Ruby 2.5 thing? Or some incompatibility
> with latest RSpec? Isn't there patch available upstream already?

Hi Vit, thanks for the remarks.
I had two kinds of errors: Guard::RSpec::RSpecProcess, Guard::RSpecFormatter.
Option "rspec --tag ~..." did not work for me, so I used "--exclude-pattern".

new spec:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec.spec
new srpm:
https://github.com/ilgrad/fedora-packages/raw/master/rubygems/rubygem-guard-rspec-4.7.3-3.fc28.src.rpm

also there is open issue with Guard::RSpecFormatter:
https://github.com/guard/guard-rspec/issues/405

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to