https://bugzilla.redhat.com/show_bug.cgi?id=1544716

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zebo...@gmail.com
           Assignee|nob...@fedoraproject.org    |zebo...@gmail.com
              Flags|                            |fedora-review?



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
> This is my first package, but I already have sponsor (I guess)

According to fas info, you are already a member of the packager group, so you
need no sponsor, you already can request repos and branches:

User: jkucera, Name: Jiri Kucera, email: jkuc...@redhat.com, Creation:
2017-10-16, IRC Nick: None, Timezone: UTC, Locale: en, GPG key ID: None,
Status: active
Approved Groups: fedorabugs packager cla_done cla_fpca


Now this package:

 - When packaging a development snapshot, you need to add the date of the
commit in the Release field. See
https://fedoraproject.org/wiki/Packaging:Versioning#Snapshots

%global commit          06d84117953b22058c096b49a429ebd4f3d3d97b
%global shortcommit     %(c=%{commit}; echo ${c:0:7})
%global commitdate      20160627

Name:           golang-%{provider}-%{project}-%{repo}
Version:        0
Release:        0.1.%{commitdate}git%{shortcommit}%{?dist}

   And then in the %changelog:

* Mon Feb 12 2018 Jiri Kucera <jkuc...@redhat.com> - 0-0.1.20160627git06d8411

 - Please add a comment explaining why the patch is needed, optionally link to
an upstream bug report or PR. (I guess this is yours
https://github.com/inconshreveable/go-vhost/pull/7 Just add it as a comment so
you'll know when to remove the patch once it has been accepted upstream).


Everything else is okay


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated". 10 files have unknown
     license. Detailed output of licensecheck in /home/bob/packaging/review
     /golang-github-inconshreveable-go-vhost/review-golang-github-
     inconshreveable-go-vhost/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gocode/src,
     /usr/share/gocode, /usr/share/gocode/src/github.com
[x]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by:
     /usr/share/gocode/src/github.com/inconshreveable(golang-github-
     inconshreveable-mousetrap-devel, golang-github-inconshreveable-muxado-
     devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
     github-inconshreveable-go-vhost-devel , golang-github-inconshreveable-
     go-vhost-unit-test-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking:
golang-github-inconshreveable-go-vhost-devel-0-0.1.git06d8411.fc28.noarch.rpm
         
golang-github-inconshreveable-go-vhost-unit-test-devel-0-0.1.git06d8411.fc28.x86_64.rpm
          golang-github-inconshreveable-go-vhost-0-0.1.git06d8411.fc28.src.rpm
golang-github-inconshreveable-go-vhost-devel.noarch: W: spelling-error
Summary(en_US) hostname -> host name, host-name, hostage
golang-github-inconshreveable-go-vhost-devel.noarch: W: spelling-error
%description -l en_US hostname -> host name, host-name, hostage
golang-github-inconshreveable-go-vhost.src: W: spelling-error Summary(en_US)
hostname -> host name, host-name, hostage
golang-github-inconshreveable-go-vhost.src: W: spelling-error %description -l
en_US hostname -> host name, host-name, hostage
3 packages and 0 specfiles checked; 0 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to