https://bugzilla.redhat.com/show_bug.cgi?id=1544468



--- Comment #17 from Daniel Kopeček <[email protected]> ---
(In reply to Steve Grubb from comment #16)
> The guidelines say we can use the variables as long as we are self
> consistent. There are no uses of %{buildroot}, so it is self consistent.

Consistent would be to use "%{optflags}" and "%{buildroot}". Or
"$RPM_OPT_FLAGS" and "$RPM_BUILD_ROOT". Macros or variables, not both. 

See the official guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

> However, its not worth discussing. I changed it and updated the FSF address.
> New spec file and SRPM are posted.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to