Zbigniew Jędrzejewski-Szmek <> changed:

           What    |Removed                     |Added
                 CC|                            |
            Summary|Review Request: sthttpd -   |Review Request: sthttpd -
                   |Tiny http server.           |Tiny http server

--- Comment #5 from Zbigniew Jędrzejewski-Szmek <> ---
Yeah, the sysusers macro shouldn't be used just yet.

Assuming that you actually want sthttpd in Fedora, here's my review:

Source0 should be a full URL.

Requires: systemd → %?systemd_requires

%setup -q + %patch0 -p1 → %autosetup -p1

%{__perl} → perl [
only suggests macros for directories, there is no reason to obfuscate
executable names like that]

/var/run → /run []

make %{?_smp_mflags} → %make_build

You shouldn't use %{SOURCE1} in the scriptlets definitions, because it might be
a full path. Use just the name of the service.
%systemd_post %{SOURCE1} → %systemd_post thttpd.service

You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
package-review mailing list --
To unsubscribe send an email to

Reply via email to