https://bugzilla.redhat.com/show_bug.cgi?id=1553999
Iwicki Artur <fed...@svgames.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |fed...@svgames.pl
--- Comment #1 from Iwicki Artur <fed...@svgames.pl> ---
>URL: https://github.com/karlstav/cava
>Source0: https://github.com/karlstav/%{name}/...
Instead of repeating this, just start Source0 with %{url}.
>Source0:
>https://github.com/karlstav/%{name}/archive/%{version}.tar.gz?/%{name}-%{version}.tar.gz
Use "/archive/%{version}/%{name}-%{version}.tar.gz" instead.
>%{_libdir}/libiniparser.so.4*
Bundling libraries should be avoided.
https://fedoraproject.org/wiki/Packaging:Guidelines#Bundling_and_Duplication_of_system_libraries
>/usr/share/consolefonts/cava.psf
This should be "%{_datadir}/consolefonts/cava.psf". Also, the "consolefonts"
directory is not owned by the package. The package must either own the
directory, or have a Requires: on another package that owns it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
