https://bugzilla.redhat.com/show_bug.cgi?id=1559864

Iwicki Artur <fed...@svgames.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fed...@svgames.pl



--- Comment #3 from Iwicki Artur <fed...@svgames.pl> ---
>Release: 0%{?dist}
This should start at 1.

>Source0: gluster-collectd-%{version}-%{_release}.tar.gz
It's preferred for Source0 to be a downloadable URL.

>cp -r conf/* %{buildroot}/%{_confdir}/
>cp -r types/* %{buildroot}/usr/share/collectd/
You should aim to preserve file timestamps. Use "cp -a" or "cp -rp". 

Also, the linked copr build failed.
>+ '%{__python2}' setup.py build
>BUILDSTDERR: /var/tmp/rpm-tmp.JzTM17: line 31: fg: no job control
The "no job control" error usually means that the macro failed to expand and
the shell is interpeting the "%" as job control. You may need to add a
BuildRequires for "python2-rpm-macros".

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to