https://bugzilla.redhat.com/show_bug.cgi?id=1565097

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zebo...@gmail.com
           Assignee|nob...@fedoraproject.org    |zebo...@gmail.com
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
7db75661589daa5cc7eccc52d52ff728f73bafb1cba008c310e803623f3ba4b6) is original.
Ok.
Summary verified from lib/Dist/Zilla/Role/ModuleMetadata.pm. Ok.
Description verified from lib/Dist/Zilla/Role/ModuleMetadata.pm. Ok.
License verified from lib/Dist/Zilla/Role/ModuleMetadata.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Dist-Zilla-Role-ModuleMetadata.spec
review-perl-Dist-Zilla-Role-ModuleMetadata/results/perl-Dist-Zilla-Role-ModuleMetadata-0.005-1.fc29.noarch.rpm
review-perl-Dist-Zilla-Role-ModuleMetadata/results/perl-Dist-Zilla-Role-ModuleMetadata-0.005-1.fc29.src.rpm
 
perl-Dist-Zilla-Role-ModuleMetadata.noarch: W: spelling-error Summary(en_US)
Metadata -> Meta data, Meta-data, Metatarsal
perl-Dist-Zilla-Role-ModuleMetadata.noarch: W: spelling-error %description -l
en_US Metadata -> Meta data, Meta-data, Metatarsal
perl-Dist-Zilla-Role-ModuleMetadata.src: W: spelling-error Summary(en_US)
Metadata -> Meta data, Meta-data, Metatarsal
perl-Dist-Zilla-Role-ModuleMetadata.src: W: spelling-error %description -l
en_US Metadata -> Meta data, Meta-data, Metatarsal
2 packages and 1 specfiles checked; 0 errors, 4 warnings.


$ rpm -q -lv -p perl-Dist-Zilla-Role-ModuleMetadata-0.005-1.fc29.noarch.rpm
drwxr-xr-x    2 root    root                        0 avril  9 18:28
/usr/share/doc/perl-Dist-Zilla-Role-ModuleMetadata
-rw-r--r--    1 root    root                     4002 avril  2 01:13
/usr/share/doc/perl-Dist-Zilla-Role-ModuleMetadata/CONTRIBUTING
-rw-r--r--    1 root    root                      608 avril  2 01:13
/usr/share/doc/perl-Dist-Zilla-Role-ModuleMetadata/Changes
-rw-r--r--    1 root    root                      399 avril  2 01:13
/usr/share/doc/perl-Dist-Zilla-Role-ModuleMetadata/README
drwxr-xr-x    2 root    root                        0 avril  9 18:28
/usr/share/licenses/perl-Dist-Zilla-Role-ModuleMetadata
-rw-r--r--    1 root    root                    18358 avril  2 01:13
/usr/share/licenses/perl-Dist-Zilla-Role-ModuleMetadata/LICENCE
-rw-r--r--    1 root    root                     2150 avril  9 18:28
/usr/share/man/man3/Dist::Zilla::Role::ModuleMetadata.3pm.gz
drwxr-xr-x    2 root    root                        0 avril  9 18:28
/usr/share/perl5/vendor_perl/Dist
drwxr-xr-x    2 root    root                        0 avril  9 18:28
/usr/share/perl5/vendor_perl/Dist/Zilla
drwxr-xr-x    2 root    root                        0 avril  9 18:28
/usr/share/perl5/vendor_perl/Dist/Zilla/Role
-rw-r--r--    1 root    root                     4186 avril  2 01:13
/usr/share/perl5/vendor_perl/Dist/Zilla/Role/ModuleMetadata.pm
File permissions and layout are Ok.

$ rpm -q --requires -p
perl-Dist-Zilla-Role-ModuleMetadata-0.005-1.fc29.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Digest::MD5)
      1 perl(Module::Metadata) >= 1.000022
      1 perl(Moose::Role)
      1 perl(namespace::autoclean)
      1 perl(strict)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p
perl-Dist-Zilla-Role-ModuleMetadata-0.005-1.fc29.noarch.rpm 
perl(Dist::Zilla::Role::ModuleMetadata) = 0.005
perl-Dist-Zilla-Role-ModuleMetadata = 0.005-1.fc29
Binary provides are Ok.

Package builds in F29
(https://koji.fedoraproject.org/koji/taskinfo?taskID=26271526)
Ok.

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to