https://bugzilla.redhat.com/show_bug.cgi?id=1564720



--- Comment #3 from Lars Kellogg-Stedman <l...@redhat.com> ---
> - Use %{_rundir} instead of /run

Done.

> - I don't think BuildRequires:  systemd is necessary.

Without that the %{_tmpfilesdir} macro is undefined.

> - Dubious files permissions:

Those are required.  It's basically just like /tmp.  I think the project should
default to using the user's home directory rather than a global directory like
that, but that's how it operates right now.

> - Files in /run should be ghosted:

Done.

> - This file should probably not included:

Good catch, fixed.

> - Some parts are also BSD and MIT

Yeah, upon inspection, the licensing is a little crazy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to