https://bugzilla.redhat.com/show_bug.cgi?id=1534052



--- Comment #5 from Robert-AndrĂ© Mauchin <[email protected]> ---
Not ok:

# force these to be installed to avoid diffs between arches
GOSRCPATH=/usr/share/gocode/src/github.com/mdlayher/netlink
install sockopt_linux.go %{buildroot}${GOSRCPATH}/sockopt_linux.go
install sockopt_linux_386.go %{buildroot}${GOSRCPATH}/sockopt_linux_386.go
install sockopt_linux_386.s %{buildroot}${GOSRCPATH}/sockopt_linux_386.s

The package should not be noarch ih this case:

It may be tempting to make the header library package noarch, since the header
files themselves are simply text. However, a library should have tests which
should be run on all architectures. Also, the install process may modify the
installed headers depending on the build architecture. For these reasons,
header-only packages must not be marked noarch.

https://fedoraproject.org/wiki/Packaging:Guidelines#Do_not_use_noarch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to