https://bugzilla.redhat.com/show_bug.cgi?id=1576836
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zebo...@gmail.com
Assignee|nob...@fedoraproject.org |zebo...@gmail.com
Flags| |fedora-review+
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
I have a deja-vu feeling about this package.
- Instead of
export CFLAGS="%{optflags}"
export CXXFLAGS="%{optflags}"
export LDFLAGS="%{__global_ldflags}"
Use simply: %set_build_flags
- Don't forget to add Version-Release infos in the %changelog:
* Wed May 9 2018 Guido Aulisi <guido.aul...@gmail.com> - 3.10-1
Package otherwise approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL", "GPL (v2 or later)", "*No copyright* GPL (v2)",
"Unknown or generated", "MIT/X11 (BSD like)", "*No copyright* LGPL
(v2.1 or later)", "ISC GPL", "GPL (v2 or later) (with incorrect FSF
address)", "LGPL (v2 or later)", "ISC", "LGPL (v2.1 or later)",
"zlib/libpng", "*No copyright* Public domain", "GPL (v3 or later)".
404 files have unknown license. Detailed output of licensecheck in
/home/bob/packaging/review/zam-plugins/review-zam-
plugins/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in lv2-zam-
plugins , ladspa-zam-plugins
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: There are rpmlint messages (see attachment).
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: zam-plugins-3.10-1.fc29.x86_64.rpm
lv2-zam-plugins-3.10-1.fc29.x86_64.rpm
ladspa-zam-plugins-3.10-1.fc29.x86_64.rpm
zam-plugins-debuginfo-3.10-1.fc29.x86_64.rpm
zam-plugins-debugsource-3.10-1.fc29.x86_64.rpm
zam-plugins-3.10-1.fc29.src.rpm
zam-plugins.x86_64: W: no-version-in-last-changelog
zam-plugins.x86_64: W: no-manual-page-for-binary ZaMaximX2
zam-plugins.x86_64: W: no-manual-page-for-binary ZaMultiComp
zam-plugins.x86_64: W: no-manual-page-for-binary ZaMultiCompX2
zam-plugins.x86_64: W: no-manual-page-for-binary ZamAutoSat
zam-plugins.x86_64: W: no-manual-page-for-binary ZamComp
zam-plugins.x86_64: W: no-manual-page-for-binary ZamCompX2
zam-plugins.x86_64: W: no-manual-page-for-binary ZamDelay
zam-plugins.x86_64: W: no-manual-page-for-binary ZamDynamicEQ
zam-plugins.x86_64: W: no-manual-page-for-binary ZamEQ2
zam-plugins.x86_64: W: no-manual-page-for-binary ZamGEQ31
zam-plugins.x86_64: W: no-manual-page-for-binary ZamGate
zam-plugins.x86_64: W: no-manual-page-for-binary ZamGateX2
zam-plugins.x86_64: W: no-manual-page-for-binary ZamHeadX2
zam-plugins.x86_64: W: no-manual-page-for-binary ZamPhono
zam-plugins.x86_64: W: no-manual-page-for-binary ZamTube
zam-plugins.x86_64: W: no-manual-page-for-binary ZamVerb
lv2-zam-plugins.x86_64: W: no-version-in-last-changelog
ladspa-zam-plugins.x86_64: W: no-version-in-last-changelog
zam-plugins-debuginfo.x86_64: W: no-version-in-last-changelog
zam-plugins-debugsource.x86_64: W: no-version-in-last-changelog
zam-plugins.src: W: no-version-in-last-changelog
6 packages and 0 specfiles checked; 0 errors, 22 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
