https://bugzilla.redhat.com/show_bug.cgi?id=1576879

Robert-André Mauchin <zebo...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zebo...@gmail.com



--- Comment #9 from Robert-André Mauchin <zebo...@gmail.com> ---
 - 0.24 is published.

 - Unbundle vendor, that might require lots of work packaging the missing deps.
Use gofed to package these.

%prep
%autosetup -n %{name}-%{version}
rm -rf vendor

Discovering package dependencies
        Class: github.com/ajeddeloh/go-json (golang-github-ajeddeloh-go-json)
PkgDB=False
        Class: github.com/aws/aws-sdk-go (golang-github-aws-aws-sdk-go)
PkgDB=True
        Class: github.com/coreos/go-semver (golang-github-coreos-go-semver)
PkgDB=True
        Class: github.com/coreos/go-systemd (golang-github-coreos-go-systemd)
PkgDB=True
        Class: github.com/pin/tftp (golang-github-pin-tftp) PkgDB=False
        Class: github.com/sigma/vmw-guestinfo
(golang-github-sigma-vmw-guestinfo) PkgDB=False
        Class: github.com/vincent-petithory/dataurl
(golang-github-vincent-petithory-dataurl) PkgDB=False
        Class: github.com/vmware/vmw-ovflib (golang-github-vmware-vmw-ovflib)
PkgDB=False

Discovering test dependencies
        Class: github.com/stretchr/testify (golang-github-stretchr-testify)
PkgDB=True


 - Consider using https://fedoraproject.org/wiki/More_Go_packaging . See
examples: https://eclipseo.fedorapeople.org/golang/

 - Thus I would not use the build script but a standard %build section like
this:

%build 
%gobuildroot
%gobuild -o _bin/ignition %{goipath}/internal
%gobuild -o _bin/ignition-validate" %{goipath}/validate

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to