https://bugzilla.redhat.com/show_bug.cgi?id=1576792



--- Comment #3 from Peter Robinson <[email protected]> ---
(In reply to Robert-André Mauchin from comment #2)
>  - Use a more meaningful archive name with:
> 
> Source0:       
> https://github.com/mozilla-iot/webthing-python/archive/v%{version}/%{name}-
> %{version}.tar.gz

When I packaged this they weren't there, it was from my request they happened:
https://github.com/mozilla-iot/webthing-python/issues/13

>  - If you only plan to support Fedora >= 28, you could use the new
> "%?python_enable_dependency_generator" instead of specifying the Requires
> manually. See https://fedoraproject.org/wiki/Changes/EnablingPythonGenerators
> 
>  - Generally we start numbering patch at 0

Actually there's no policy about that, it's up to the packager.

>  - I think you should name this package python-webthing and provide a Python
> 3 subpackage. You could use pyp2rpm to help with that: pyp2rpm -b3 webthing
> > python-webthing.spec and then adjust the patch, license, description.

I'm considering that, although I'd use python3-webthing naming because I have
no intention of supporting py2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]

Reply via email to