https://bugzilla.redhat.com/show_bug.cgi?id=1577404
Darryl T. Agostinelli <dagostine...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dagostine...@gmail.com
--- Comment #3 from Darryl T. Agostinelli <dagostine...@gmail.com> ---
This is an informal review.
- What files are installed?
In %files, it seems to be only specifying the COPYING file. Are there any
other files that get installed as part of this besides the license file? I saw
your response to Robert-André Mauchin, but I didn't see the file before now. It
still looks like files are missing.
- %prep
In %prep, consider using `autosetup` to handle the unzipping for you. autosetup
handles the peculiarities of how GitHub composes its zip files.
ex:
%prep
%autosetup -n %{name}-%{version}
- %build
In %build, it seems like the %configure/%make_build/%make_install macros might
simplify this.
- No:
%global debug_package %{nil}
Do your best to generate debug symbols.
- fedora-review fails with
$ fedora-review -b 1577404
INFO: Processing bugzilla bug: 1577404
INFO: Getting .spec and .srpm Urls from : 1577404
INFO: --> SRPM url:
https://aacosta.fedorapeople.org/rpmdevel/kaldi-5.3-1.fc28.src.rpm
INFO: --> Spec url: https://aacosta.fedorapeople.org/rpmdevel/kaldi-5.3.spec
INFO: Using review directory: /home/dagostinelli/connections/1577404-kaldi-5.3
INFO: Downloading .spec and .srpm files
INFO: Downloading (Source0): https://github.com/kaldi-asr/kaldi/archive/5.3.zip
INFO: Running checks and generating report
INFO: Results and/or logs in:
/home/dagostinelli/connections/1577404-kaldi-5.3/results
INFO: WARNING: Probably non-rawhide buildroot used. Rawhide should be used for
most package reviews
INFO: Build completed
INFO: Installing built package(s)
INFO: Install command returned error code 30
INFO: Active plugins: Generic, Shell-api
Last metadata expiration check: 2:50:58 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:51:02 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:51:07 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:51:11 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:51:14 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:51:19 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:53:34 ago on Wed 16 May 2018 06:00:44 PM CDT.
Last metadata expiration check: 2:53:36 ago on Wed 16 May 2018 06:00:44 PM CDT.
INFO: ExclusiveArch dependency checking disabled, enable with EXARCH flag
- rpmlint has errors
Rpmlint
-------
Checking: kaldi-5.3-1.fc25.x86_64.rpm
kaldi-5.3-1.fc25.src.rpm
kaldi.x86_64: E: explicit-lib-dependency libtool
kaldi.x86_64: E: devel-dependency zlib-devel
kaldi.x86_64: E: description-line-too-long C Kaldi is a toolkit for speech
recognition, intended for use by speech recognition researchers and
professionals.
kaldi.x86_64: E: no-binary
kaldi.x86_64: W: no-documentation
kaldi.src: E: description-line-too-long C Kaldi is a toolkit for speech
recognition, intended for use by speech recognition researchers and
professionals.
kaldi.src: E: invalid-spec-name
kaldi.src:19: W: macro-in-comment %autosetup
kaldi.src:33: W: macro-in-comment %{name}
kaldi.src:33: W: macro-in-comment %{version}
kaldi.src:37: W: macro-in-comment %make
kaldi.src:39: W: macro-in-comment %{name}
kaldi.src:39: W: macro-in-comment %{version}
2 packages and 0 specfiles checked; 6 errors, 7 warnings.
- mock
fedora-review will run mock internally, but you can also run it standalone. It
has errors from the fedora-review. I got:
ERROR: Command failed:
# /usr/bin/dnf --installroot /var/lib/mock/fedora-25-x86_64/root/ --releasever
25 --disableplugin=local --setopt=deltarpm=False install
/home/dagostinelli/connections/1577404-kaldi-5.3/results/kaldi-5.3-1.fc25.x86_64.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
