https://bugzilla.redhat.com/show_bug.cgi?id=1578152

Jitka Plesnikova <jples...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jples...@redhat.com> ---
Source file is ok

License of Minion is Artistic 2.0
FIX: Please add also license 'MIT' and 'OFL', because Minion includes a few
     files with different licenses. More info can be found in
     Minion-9.03/lib/Minion.pm line 803 and in files bootstrap.css,
     bootstrap.js, fontawesome.css, popper.js

Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Minion-9.03-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(Config)
      1 perl(Minion)
      1 perl(Minion::Job)
      1 perl(Minion::Worker)
      1 perl(:MODULE_COMPAT_5.26.2)
      1 perl(Mojo::Base)
      1 perl(Mojo::Date)
      1 perl(Mojo::File)
      1 perl(Mojo::IOLoop)
      1 perl(Mojo::JSON)
      1 perl(Mojo::Loader)
      1 perl(Mojo::Pg) >= 4.0
      1 perl(Mojo::Server)
      1 perl(Mojo::Util)
      1 perl(POSIX)
      1 perl(Scalar::Util)
      1 perl(Sys::Hostname)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Minion-9.03-1.fc29.noarch.rpm | sort | uniq -c
      1 perl(Minion) = 9.03
      1 perl-Minion = 9.03-1.fc29
      1 perl(Minion::Backend)
      1 perl(Minion::Backend::Pg)
      1 perl(Minion::Command::minion)
      1 perl(Minion::Command::minion::job)
      1 perl(Minion::Command::minion::worker)
      1 perl(Minion::_Guard)
      1 perl(Minion::Job)
      1 perl(Minion::Worker)
      1 perl(Mojolicious::Plugin::Minion)
      1 perl(Mojolicious::Plugin::Minion::Admin)
Binary provides are Ok.

$ rpmlint ./perl-Minion*
perl-Minion.noarch: W: summary-not-capitalized C a high performance job queue
for the Perl programming language
perl-Minion.noarch: W: spelling-error %description -l en_US backoff -> back
off, back-off, kickoff
perl-Minion.noarch: W: spelling-error %description -l en_US autoscaling -> auto
scaling, auto-scaling, automobiling
perl-Minion.noarch: W: spelling-error %description -l en_US ui -> ii, u, i
perl-Minion.src: W: summary-not-capitalized C a high performance job queue for
the Perl programming language
perl-Minion.src: W: spelling-error %description -l en_US backoff -> back off,
back-off, kickoff
perl-Minion.src: W: spelling-error %description -l en_US autoscaling -> auto
scaling, auto-scaling, automobiling
perl-Minion.src: W: spelling-error %description -l en_US ui -> ii, u, i
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

Summary is ok
FIX: Just replace 'a high' with 'A high'

Please correct all 'FIX' issues.

Otherwise the package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

Reply via email to