https://bugzilla.redhat.com/show_bug.cgi?id=1583608
--- Comment #3 from Robert-André Mauchin <[email protected]> --- Please use the new Golang packaging guidelines. Your SPEC looks like a mix of the old and new way: Instead of %global provider_prefix github.com/10gen/escaper %global import_path %{provider_prefix} %global goipath %{import_path} %global commit 17fe61c658dcbdcbf246c783f4f7dc97efde3a8b %global commitdate 20180528 Simply use: %global goipath github.com/10gen/escaper %global commit 17fe61c658dcbdcbf246c783f4f7dc97efde3a8b - Not needed, it is set by gometa: %global debug_package %{nil} - The Release tag is automatically calculated, simply use Release: 0.1%{?dist} - Use URL: %{gourl} - Not needed, it is set by %gometa # e.g. el6 has ppc64 arch without gcc-go, so EA tag is required ExclusiveArch: %{ix86} x86_64 %{arm} aarch64 ppc64le s390x # If go_compiler is not set to 1, there is no virtual provide. Use golang instead. BuildRequires: %{?go_compiler:compiler(go-compiler)}%{!?go_compiler:golang} - Remove the unnecessary condition: %if 0%{?with_devel} - Not needed it is set automatically: Provides: golang(%{import_path}) = %{version}-%{release} - Use the %gochecks macro for the tests: %check %gochecks - Not needed: #define license tag if not already defined %{!?_licensedir:%global license %doc} - %changelog should be: * Mon May 28 2018 [email protected] - 0-0.1.20180528git17fe61c - Capitalize the initial letter of the summary. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]/message/YL3CK7THISPWB2NXIDXXP7QZ2J2DUS2W/
