https://bugzilla.redhat.com/show_bug.cgi?id=1582876



--- Comment #5 from Neal Gompa <[email protected]> ---
> - "make %{?_smp_mflags}" is used. Please consider "%make_build"

I'm mainly using "make %{?_smp_mflags}" for symmetry with the custom install
command, but I can change it if desired.

> - No license file for bundled library. Even though it is not explicitly 
> required in the guidelines I would think we need a copy of it to be provided 
> since we are shipping the library. Upstream may be dead so an external copy 
> of the file may be required.

We're explicitly not supposed to do that:

> If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/OILSO4UWFDK3EXK33CJL7PV5F3TQASMS/

Reply via email to