https://bugzilla.redhat.com/show_bug.cgi?id=1585565



--- Comment #3 from Mohammed Isam <[email protected]> ---
(In reply to Artur Iwicki from comment #2)
> >Group: Applications/Accessories
> Drop this.
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

I dropped this, and the %clean section, as in the guidelines.

> >%post
> >/bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null || :
> >/usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> >
> >%postun
> >if [ $1 -eq 0 ] ; then
> >    /bin/touch --no-create %{_datadir}/icons/hicolor &>/dev/null
> >    /usr/bin/gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
> >fi
> The icon cache scriptlets are no longer needed. Remove them and add
> "Requires: hicolor-icon-theme" instead.

Fixed.

> >%files
> >%{_datadir}/icons/hicolor/256x256/apps/%{name}.png
> >%{_datadir}/icons/hicolor/48x48/apps/%{name}.png
> >%{_datadir}/icons/hicolor/24x24/apps/%{name}.png
> In %files, you can use "aaa/*/bbb" to match multiple directories.

Fixed.

> 
> >%files
> >%%doc AUTHORS NEWS THANKS README COPYING ChangeLog
> Mark COPYING as %license.

Fixed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/ICOAACXNDIFN6SHYXJQJWBXMUSY5OMB3/

Reply via email to