https://bugzilla.redhat.com/show_bug.cgi?id=1591473

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-AndrĂ© Mauchin <[email protected]> ---
 - Not needed:

Group:

rm -rf -- "%{buildroot}"

%clean
rm -rf -- "%{buildroot}"

%defattr(-,root,root,-)

 - Source0 should be d/l from a remote source:

Source0:   
https://github.com/dell/sassist/archive/%{version}/%{name}-%{version}.tar.gz

 - Should't be needed:

Requires: systemd-units
Requires(post): systemd-units
Requires(postun): systemd-units

Requires: systemd

   it is implied by %{?systemd_requires}.

 - However you need:

BuildRequires: systemd

 - The license must be installed with %license:

%license COPYING

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/TCC2VHPGYR7MMIUS4HV6VKAGBTR7USW3/

Reply via email to