https://bugzilla.redhat.com/show_bug.cgi?id=1519785



--- Comment #18 from Ben Rosser <[email protected]> ---
Two hopefully final comments:

1. Please don't forget to add "%license COPYING" to include the license file in
the package, under the %files section. This will automatically include the
license.

2. 

> warning: bogus date in %changelog: Tue Jun 13 2018 Jan De Luyck 
> <[email protected]> 1.4.8-1

I think you mean either "Wed Jun 13 2018" or "Tue Jun 12 2018". Note that
"rpmdev-bumpsec" can automatically generate changelog entries for you.

Otherwise, this looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/IF44KM2WECDPGKXDPV3Z2VIDTUDWMO57/

Reply via email to