https://bugzilla.redhat.com/show_bug.cgi?id=1581240
--- Comment #4 from Robert-André Mauchin <zebo...@gmail.com> --- Using SPEC URL: https://copr-be.cloud.fedoraproject.org/results/avigne/pcb-rnd/fedora-rawhide-x86_64/00763485-pcb-rnd/pcb-rnd.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/avigne/pcb-rnd/fedora-rawhide-x86_64/00763485-pcb-rnd/pcb-rnd-2.0.0-1.fc29.src.rpm - Add a comment explaining the licenses breakdown: [!]: If the package is under multiple licenses, the licensing breakdown - Use %{_prefix} instead of %{_usr} %{_prefix}/lib/%{name}/*.scm - Shouldn't be needed: %exclude %{_usr}/lib/debug/* Debug files are automatically picked up by the debug packages. - Own these directories: [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/pcb-rnd, /usr/lib /pcb-rnd, /usr/lib/pcb-rnd/plugins, /usr/share/doc/pcb-rnd Note: remove the * here to also own the dirs: %files doc %doc %{_docdir}/%{name} %files core %{_bindir}/fp2anim %{_bindir}/fp2subc %{_bindir}/gsch2%{name} %{_bindir}/pcb-prj2lht %{_bindir}/%{name} %{_bindir}/pcb-strip %{_mandir}/man1/* %{_datadir}/%{name} %dir %{_prefix}/lib/%{name} %dir %{_prefix}/lib/%{name}/plugins %{_prefix}/lib/%{name}/*.scm - Notify upstream about the erroneous FSF address in COPYING: pcb-rnd-core.x86_64: E: incorrect-fsf-address /usr/share/licenses/pcb-rnd-core/COPYING - Use %global, not %define: [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug 0, %define plugindir %{_usr}/lib/%{name}/plugins, #%%define svn 15165 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL (v2 or later)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* GPL", "GPL (v2 or later) (with incorrect FSF address)", "BSD (3 clause)", "GPL (v2) (with incorrect FSF address)", "LGPL (v2.1 or later)", "GPL (v2)". 2646 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/pcb-rnd/review-pcb-rnd/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/pcb-rnd, /usr/share/pcb-rnd, /usr/share/doc/pcb-rnd [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/pcb-rnd, /usr/lib /pcb-rnd, /usr/lib/pcb-rnd/plugins, /usr/share/doc/pcb-rnd [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in pcb-rnd- core , pcb-rnd-auto , pcb-rnd-cloud , pcb-rnd-debug , pcb-rnd-export- extra , pcb-rnd-export-sim , pcb-rnd-export , pcb-rnd-extra , pcb-rnd- hid-gtk2-gdk , pcb-rnd-hid-gtk2-gl , pcb-rnd-hid-lesstif , pcb-rnd- import-geo , pcb-rnd-import-net , pcb-rnd-io-alien , pcb-rnd-io- standard , pcb-rnd-lib-gl , pcb-rnd-lib-gtk , pcb-rnd-lib-gui , pcb- rnd-lib-io [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define debug 0, %define plugindir %{_usr}/lib/%{name}/plugins, #%%define svn 15165 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: pcb-rnd-2.0.0-1.fc29.x86_64.rpm pcb-rnd-core-2.0.0-1.fc29.x86_64.rpm pcb-rnd-doc-2.0.0-1.fc29.noarch.rpm pcb-rnd-auto-2.0.0-1.fc29.x86_64.rpm pcb-rnd-cloud-2.0.0-1.fc29.x86_64.rpm pcb-rnd-debug-2.0.0-1.fc29.x86_64.rpm pcb-rnd-export-extra-2.0.0-1.fc29.x86_64.rpm pcb-rnd-export-sim-2.0.0-1.fc29.x86_64.rpm pcb-rnd-export-2.0.0-1.fc29.x86_64.rpm pcb-rnd-extra-2.0.0-1.fc29.x86_64.rpm pcb-rnd-hid-gtk2-gdk-2.0.0-1.fc29.x86_64.rpm pcb-rnd-hid-gtk2-gl-2.0.0-1.fc29.x86_64.rpm pcb-rnd-hid-lesstif-2.0.0-1.fc29.x86_64.rpm pcb-rnd-import-geo-2.0.0-1.fc29.x86_64.rpm pcb-rnd-import-net-2.0.0-1.fc29.x86_64.rpm pcb-rnd-io-alien-2.0.0-1.fc29.x86_64.rpm pcb-rnd-io-standard-2.0.0-1.fc29.x86_64.rpm pcb-rnd-lib-gl-2.0.0-1.fc29.x86_64.rpm pcb-rnd-lib-gtk-2.0.0-1.fc29.x86_64.rpm pcb-rnd-lib-gui-2.0.0-1.fc29.x86_64.rpm pcb-rnd-lib-io-2.0.0-1.fc29.x86_64.rpm pcb-rnd-debuginfo-2.0.0-1.fc29.x86_64.rpm pcb-rnd-debugsource-2.0.0-1.fc29.x86_64.rpm pcb-rnd-2.0.0-1.fc29.src.rpm pcb-rnd.x86_64: E: no-binary pcb-rnd.x86_64: W: no-documentation pcb-rnd-core.x86_64: E: incorrect-fsf-address /usr/share/licenses/pcb-rnd-core/COPYING pcb-rnd-auto.x86_64: W: spelling-error Summary(en_US) Autoroute -> Auto route, Auto-route, Automate pcb-rnd-auto.x86_64: W: spelling-error Summary(en_US) autoplace -> auto place, auto-place, outplace pcb-rnd-auto.x86_64: W: no-documentation pcb-rnd-cloud.x86_64: W: spelling-error %description -l en_US edakrill -> espadrille pcb-rnd-cloud.x86_64: W: spelling-error %description -l en_US gedasymbols -> symbols pcb-rnd-cloud.x86_64: W: no-documentation pcb-rnd-debug.x86_64: W: no-dependency-on pcb-rnd/pcb-rnd-libs/libpcb-rnd pcb-rnd-debug.x86_64: W: no-documentation pcb-rnd-export-extra.x86_64: W: spelling-error %description -l en_US fidocadj -> aficionado pcb-rnd-export-extra.x86_64: W: spelling-error %description -l en_US ipc -> pic, inc pcb-rnd-export-extra.x86_64: W: spelling-error %description -l en_US lpr -> pr, ppr, Apr pcb-rnd-export-extra.x86_64: W: no-documentation pcb-rnd-export-sim.x86_64: W: spelling-error %description -l en_US openems -> openers, open ems, open-ems pcb-rnd-export-sim.x86_64: W: no-documentation pcb-rnd-export.x86_64: W: spelling-error %description -l en_US svg -> avg, sag, VG pcb-rnd-export.x86_64: W: spelling-error %description -l en_US ps -> PS, pa, pd pcb-rnd-export.x86_64: W: spelling-error %description -l en_US eps -> esp, rps, es pcb-rnd-export.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang pcb-rnd-export.x86_64: W: spelling-error %description -l en_US jpeg -> JPEG, peg, j peg pcb-rnd-export.x86_64: W: spelling-error %description -l en_US gerber -> Gerber, Berber, Ferber pcb-rnd-export.x86_64: W: spelling-error %description -l en_US openscad -> open scad, open-scad, opens cad pcb-rnd-export.x86_64: W: spelling-error %description -l en_US xy -> x, y, xi pcb-rnd-export.x86_64: W: no-documentation pcb-rnd-extra.x86_64: W: spelling-error %description -l en_US subcircuits -> sub circuits, sub-circuits, circuits pcb-rnd-extra.x86_64: W: no-documentation pcb-rnd-hid-gtk2-gdk.x86_64: W: no-documentation pcb-rnd-hid-gtk2-gl.x86_64: W: spelling-error Summary(en_US) opengl -> opening pcb-rnd-hid-gtk2-gl.x86_64: W: spelling-error %description -l en_US opengl -> opening pcb-rnd-hid-gtk2-gl.x86_64: W: no-documentation pcb-rnd-hid-lesstif.x86_64: W: no-documentation pcb-rnd-import-geo.x86_64: W: no-documentation pcb-rnd-import-net.x86_64: W: spelling-error Summary(en_US) Netlist -> Net list, Net-list, Listerine pcb-rnd-import-net.x86_64: W: spelling-error %description -l en_US netlist -> net list, net-list, Listerine pcb-rnd-import-net.x86_64: W: spelling-error %description -l en_US edif -> edify, edit, ed if pcb-rnd-import-net.x86_64: W: spelling-error %description -l en_US ltspice -> spice pcb-rnd-import-net.x86_64: W: spelling-error %description -l en_US gschem -> gs chem, gs-chem, scheme pcb-rnd-import-net.x86_64: W: spelling-error %description -l en_US tinycad -> tiny cad, tiny-cad, tinny pcb-rnd-import-net.x86_64: W: no-documentation pcb-rnd-io-alien.x86_64: W: spelling-error %description -l en_US protel -> propel, pro tel, pro-tel pcb-rnd-io-alien.x86_64: W: spelling-error %description -l en_US autotrax -> autocrat pcb-rnd-io-alien.x86_64: W: no-documentation pcb-rnd-io-standard.x86_64: W: spelling-error %description -l en_US tEDAx -> ted Ax, ted-ax, dated pcb-rnd-io-standard.x86_64: W: spelling-error %description -l en_US gEDA -> egad, aged, Leda pcb-rnd-io-standard.x86_64: W: no-documentation pcb-rnd-lib-gl.x86_64: W: spelling-error Summary(en_US) opengl -> opening pcb-rnd-lib-gl.x86_64: W: spelling-error %description -l en_US opengl -> opening pcb-rnd-lib-gl.x86_64: W: no-documentation pcb-rnd-lib-gtk.x86_64: W: no-documentation pcb-rnd-lib-gui.x86_64: W: no-documentation pcb-rnd-lib-io.x86_64: W: no-documentation pcb-rnd.src:206: W: configure-without-libdir-spec 24 packages and 0 specfiles checked; 2 errors, 52 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/HUMP4PEPGFAN7KWYZYLX4SKKTJRUSJFA/
