https://bugzilla.redhat.com/show_bug.cgi?id=1586291



--- Comment #14 from Vít Ondruch <vondr...@redhat.com> ---
(In reply to Alois Mahdal from comment #9)
> (In reply to Robert-André Mauchin from comment #7)
> >  - libslopy-devel should Requires libslopy:
> > 
> > %package -n libslopy-devel
> > Summary:    Select Operation
> > Requires:   libslopy%{?_isa} = %{version}-%{release}
> 
> I've added them back, although note that IIUC Vít's comment 1 seems to
> suggest that they should be generated by cmake, and with previous builds I
> could observe that was the case.

Sorry, my remark was quite brief without enough context. I was definitely
referring to the main package only and I was not 100 % sure, because I have not
checked it. This is how it looks in your last build:

~~~
$ rpm -qpR
https://kojipkgs.fedoraproject.org//work/tasks/4677/27864677/libslopy-devel-7.4-1.fc28.x86_64.rpm
| grep slop
libslopy.so.7.4()(64bit)
slop(x86-64) = 7.4-1.fc28
~~~

As you can see, there is autogenerated dependency on the library.

The -devel subpackage is a bit different case and it is explicitly mentioned in
these chapters of guildeines:

https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package

However, there is also the dependency autogenerated:

~~~
$ rpm -qpR
https://kojipkgs.fedoraproject.org//work/tasks/4677/27864677/libslopy-devel-7.4-1.fc28.x86_64.rpm
| grep slop
libslopy.so.7.4()(64bit)
slop(x86-64) = 7.4-1.fc28
~~~

So strictly speaking, it should not be required to specify the dependency
explicitly. But it depends case by case, what is contained in which package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/ENINCRMASW4ZPV4LS5YIVYWX42B5ZLO7/

Reply via email to