https://bugzilla.redhat.com/show_bug.cgi?id=1595420
--- Comment #2 from Alois Mahdal <amah...@redhat.com> ---
(In reply to Robert-André Mauchin from comment #1)
> - You should package it with Python 3 not Python 2. Python 2 will be phased
> out from Fedora near 2020:
>
> - You should include the Python provide macro:
>
> BuildRequires: python3-devel
>
> And:
>
> %package -n python3-%{name}
> Summary: %{summary}
> %{?python_provide:%python_provide python3-%{name}}
>
> %description -n python3-%{name}
> Python library that implements API used by ydiff tool.
>
>
> And:
>
> %files -n python3-%{name}
> %{python3_sitelib}/__pycache__/*
> %{python3_sitelib}/%{name}.py
> %{python3_sitelib}/%{name}-%{version}-py?.?.egg-info
(I was under the impression that ydiff did not support Python3, looks
like I was wrong.)
I've added the py3 gear. However, the guideline does not seem to match
perfectly on this layout where binary is packaged as own sub-package.
So I "stole" what was missing from fmf/fmf.spec (in particular, the
ydiff subpackage should require and use the python3-ydiff.
> - Should not be needed in %files
>
> %{python2_sitelib}/%{name}.pyc
> %{python2_sitelib}/%{name}.pyo
Anyway, I do get errors when I remove them.
RPM build errors:
error: Installed (but unpackaged) file(s) found:
/usr/lib/python2.7/site-packages/ydiff.pyc
/usr/lib/python2.7/site-packages/ydiff.pyo
Installed (but unpackaged) file(s) found:
/usr/lib/python2.7/site-packages/ydiff.pyc
/usr/lib/python2.7/site-packages/ydiff.pyo
The guide actually says that the files should be included, although
it's not clear if that should be done explicity in %files or some RPM
automation does it.
I'll post new version in few minutes.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/PQUVJJRLJ3USRBPK2MGSCKK4JUTBX3N2/
