https://bugzilla.redhat.com/show_bug.cgi?id=1594313
--- Comment #12 from jiri vanek <jva...@redhat.com> ---
(In reply to Severin Gehwolf from comment #6)
> (In reply to jiri vanek from comment #5)
> > (In reply to Severin Gehwolf from comment #3)
> > > Source0: jdk-jdk-jdk-%{majorver}+%{buildver}.tar.xz
> > > Source1: jdk-shenandoah-jdk-ac148db384ee.tar.xz
> > > Source8: systemtap-tapset-3.6.0pre02.tar.xz
> > >
> > > Each of these sources should have a comment preceding them how *exactly*
> > > the
> > > tarball was generated. I've been asked before by other fedora contributors
> > > how our sources are generated. When being asked I mostly don't remember
> > > myself and need to go digging. If every source was preceded by a comment
> > > where it came from those issues go away. Example:
> > >
> > > # Generated by:
> > > # $ VERSION="jdk-11+19" PROJECT_NAME=jdk REPO_NAME=jdk bash
> >
> > This kind of comment should not be necessary.
>
> It's absolutely necessary.
>
> > Those valueas are exactly for
> > this purpose hardcoded in update_package.sh
>
> Yet, nothing mentions "update_package.sh" in Source{0,1,8} comments. So for
> somebody new to the package, why would they look at update_package.sh? They
> wouldn't. There is "generate_source_tarball.sh", "generate_tarballs.sh" and
> "update_package.sh" as auxiliary scripts. Knowing nothing about a specific
> work-flow one is lost which one to use for which tarball source. Then by the
> time they've looked at the third script they are giving up trying to figure
> out the exact parameters one is supposed to invoke scripts with and ask for
> help. This absolutely needs to become easier to self-discover. Hiding
> something in extra scripts isn't enough. Remember, the audience is somebody
> who knows about RPM packaging. The expectation should be to go to the spec
> file and figure out the rest on their own. That's hard enough for OpenJDK
> spec files already. We don't need to make it even harder by introducing 3
> levels of indirection ;-)
>
> If update_packages.sh satisfies *your* work-flow, then it should be possible
> to massage that script to output the parameters used to generate a
> sourcetarball. After that it's a matter of adding that comment.
Fixed. All three scripts needs a bit of tweeking. Will tune them during next
update pf sources
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/RJBQR726ZDZSVRVFBIJIY62EJHGDEFJY/
