https://bugzilla.redhat.com/show_bug.cgi?id=1594431

Robert-AndrĂ© Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Review Request:             |Review Request: unicorn - A
                   |python-unicorn - A          |lightweight multi-platform,
                   |lightweight multi-platform, |multi-architecture CPU
                   |multi-architecture CPU      |emulator framework
                   |emulator framework          |



--- Comment #5 from Robert-AndrĂ© Mauchin <[email protected]> ---
License:        GPLv2 LGPLv2+ MIT BSD

   Separate each license by and:

License:        GPLv2 and LGPLv2+ and MIT and BSD

 - Add gcc to the BR

 - COPYING must be installed with %license, not %doc:

%doc AUTHORS.TXT ChangeLog CREDITS.TXT README.md
%license COPYING

 - SPEC and bug should be renamed to unicorn.spec / unicorn

 - Use a more meaningful name for the archive:

Source0:       
https://github.com/unicorn-engine/%{name}/archive/%{version}/%{name}-%{version}.tar.gz

 - You install a library in libdir, you should run: %ldconfig_scriptlets

   Read
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets#Upgrade.2Fcompatibility_impact

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/XO6NR6LW5HI43J5AVD5RPHOQKX4EHNZK/

Reply via email to