https://bugzilla.redhat.com/show_bug.cgi?id=1601058



--- Comment #3 from Michael Catanzaro <[email protected]> ---
Is it conventional to use uppercase in package names? I would probably call it
"wpebackend".

I'd use a glob in the file list:

%{_includedir}/wpe-0.1/wpe/*.h

because you don't want the build to break every time a header gets added or
removed. (Only two of the headers may be used directly by applications, and
they won't disappear unexpectedly.)

You will surely want to use a glob to avoid build failures when the last two
components of the soversion change in every release:

%{_libdir}/libWPEBackend-0.1.so.0.*

Looks like you have one extra space here in the devel package requires:

Requires:       %{name}%{?_isa} = %{version}-%{release}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/5GMUSWCZHIE5S3ED7RZLEWQPKCS3GPOB/

Reply via email to