https://bugzilla.redhat.com/show_bug.cgi?id=1601186



--- Comment #3 from Chris King <[email protected]> ---
(In reply to Michael Catanzaro from comment #1)
> Were you able to successfully run the minibrowser? It cannot work unless you
> additionally package a WPE backend (e.g. WPEBackend-fdo).

That is something I've been wondering about, the minibrowser isn't even in the
install files, despite my building with the cmake flage of
ENABLE_MINIBROWSER=ON. I don't know as much about the inner workings of
webkit/WPE as you probably do, so help on this would be great. 

I have packaged wpebackend-fdo 0.1 in my copr repository, I can also make a
package review request for that if you think that'll be necessary.

I also wouldn't be against possibly packaging the cog frontend, but it doesn't
seem to be mature enough yet to have any versioned releases(?)

> We'll need to duplicate the fedora-crypto patch in both packages forever,
> yes.

Okay, I've included that in the new spec.

> User agent patch is optional.

In that case I won't include it.

> The python patch should only be needed to avoid a build failure, so if it
> builds successfully on rawhide without it, then it should probably be
> dropped.

My build is succeeding on f28 but not on rawhide, I think that this might be
the issue. currently running a copr build with the python2 patch and I'll get
back to you on if that fixes it.

> -DCMAKE_EXE_LINKER_FLAGS="${CMAKE_EXE_LINKER_FLAGS} -lrt" should indeed not
> be needed, would be good to add a FIXME to figure out how to remove that.

Trying to build without this fails in copr, so I guess it's not just my
machine, what is the process for adding a FIXME?

New spec:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/WPE-webkit/fedora-rawhide-x86_64/00777901-wpewebkit/wpewebkit.spec

New srpm:
https://copr-be.cloud.fedoraproject.org/results/bunnyapocalypse/WPE-webkit/fedora-rawhide-x86_64/00777901-wpewebkit/wpewebkit-2.20.1-2.fc29.src.rpm

Thanks for all of the help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/Y4BUGUKGMYWHL6FHIAHA2AIU7MU3LTQB/

Reply via email to