https://bugzilla.redhat.com/show_bug.cgi?id=1608401

Pierre-YvesChibon <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
              Flags|                            |fedora-review+



--- Comment #1 from Pierre-YvesChibon <[email protected]> ---
* Spec is nice and clean
  - I'd recommend using the new %pypi_source macro but that's at your option
  - I'd also recommend including the CHANGES.txt in the %doc (though looking at
the MANIFEST.in I'm not sure upstream ships it in their tarball)
  - I'd recommend asking upstream to include their LICENSE.txt file so it can
be flagged in the spec file
* Builds fine in all arches:
  https://koji.fedoraproject.org/koji/taskinfo?taskID=28595642
* License is valid and correct
* Basic test of the code shows no error:
   >>> import pyperclip
   >>> pyperclip.copy('foo')
   >>> pyperclip.paste()
   'foo'

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/AMJAWN4VQEW63ROTVKYEVINDK2CJJDU3/

Reply via email to