https://bugzilla.redhat.com/show_bug.cgi?id=1609465
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- Capitalize the summary
- %ldconfig_scriptlets: you can safely remove this if you don't plan to
support F27. See
https://fedoraproject.org/wiki/Changes/Removing_ldconfig_scriptlets
- Replace .gz by .* as the compression may change in the future
%{_mandir}/man1/mobi*.1.*
- It is now recommended not to use a glob for the SONAME major version to
avoid bumping the library accidentally (see
https://pagure.io/packaging-committee/issue/784):
%{_libdir}/%{name}.so.0.*
- Remove rpath:
libmobi-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mobimeta
['/usr/lib64']
libmobi-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mobitool
['/usr/lib64']
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Rpath absent or only used for internal libs.
Note: See rpmlint output
[x]: If your application is a C or C++ application you must list a
BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "GPL", "GPL (v3)", "Unknown or
generated". 68 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/libmobi/review-
libmobi/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libmobi-
debuginfo , libmobi-debugsource
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on debuginfo package(s).
Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
is arched.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: libmobi-0.4-1.fc29.x86_64.rpm
libmobi-tools-0.4-1.fc29.x86_64.rpm
libmobi-devel-0.4-1.fc29.x86_64.rpm
libmobi-debuginfo-0.4-1.fc29.x86_64.rpm
libmobi-debugsource-0.4-1.fc29.x86_64.rpm
libmobi-0.4-1.fc29.src.rpm
libmobi.x86_64: W: spelling-error Summary(en_US) ebook -> book, e book
libmobi.x86_64: W: summary-not-capitalized C library for handling Kindle (MOBI)
formats of ebook documents
libmobi.x86_64: W: spelling-error %description -l en_US pdb -> pd, db, pub
libmobi.x86_64: W: spelling-error %description -l en_US prc -> PRC, pr, pic
libmobi.x86_64: W: spelling-error %description -l en_US mobi -> mob, moi, obi
libmobi.x86_64: W: spelling-error %description -l en_US azw -> aw, AZ
libmobi.x86_64: W: spelling-error %description -l en_US html -> HTML, ht ml,
ht-ml
libmobi.x86_64: W: spelling-error %description -l en_US kindlegen -> kindle
gen, kindle-gen, kindle
libmobi.x86_64: W: spelling-error %description -l en_US orth -> north, forth,
worth
libmobi.x86_64: W: spelling-error %description -l en_US infl -> inf, info, incl
libmobi.x86_64: W: no-documentation
libmobi-tools.x86_64: W: summary-not-capitalized C libmobi CLI tools
libmobi-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mobimeta
['/usr/lib64']
libmobi-tools.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mobitool
['/usr/lib64']
libmobi-tools.x86_64: W: manual-page-warning /usr/share/man/man1/mobimeta.1.gz
15: warning: macro `.' not defined
libmobi-tools.x86_64: W: manual-page-warning /usr/share/man/man1/mobitool.1.gz
14: warning: macro `.' not defined
libmobi-devel.x86_64: W: no-documentation
libmobi.src: W: spelling-error Summary(en_US) ebook -> book, e book
libmobi.src: W: summary-not-capitalized C library for handling Kindle (MOBI)
formats of ebook documents
libmobi.src: W: spelling-error %description -l en_US pdb -> pd, db, pub
libmobi.src: W: spelling-error %description -l en_US prc -> PRC, pr, pic
libmobi.src: W: spelling-error %description -l en_US mobi -> mob, moi, obi
libmobi.src: W: spelling-error %description -l en_US azw -> aw, AZ
libmobi.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
libmobi.src: W: spelling-error %description -l en_US kindlegen -> kindle gen,
kindle-gen, kindle
libmobi.src: W: spelling-error %description -l en_US orth -> north, forth,
worth
libmobi.src: W: spelling-error %description -l en_US infl -> inf, info, incl
6 packages and 0 specfiles checked; 2 errors, 25 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org/message/AGZJUOWCXE6RQ5AMTFNTUSYED63DODKH/
