https://bugzilla.redhat.com/show_bug.cgi?id=1603146



--- Comment #2 from Igor Gnatenko <[email protected]> ---
Ugh, I was pretty sure I did the review. I'm very sorry.

> Source: cockpit-ostree-%{version}.tar.gz

Add some comment how to obtain it.

> %build
> # There is nothing to do, release tarballs already have dist/.

Remove this entirely.

> make install DESTDIR=%{buildroot}

%make_install

> find %{buildroot} -type f >> files.list
> sed -i "s|%{buildroot}find %{buildroot} -type f >> files.list
sed -i "s|%{buildroot}||" *.list||" *.list

Isn't there some better way? Also what about directory ownership?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]/message/NEMWVVEP73NPRAIPZANB7QZQILRRDKAR/

Reply via email to