https://bugzilla.redhat.com/show_bug.cgi?id=1614504
--- Comment #3 from [email protected] --- (In reply to Artur Iwicki from comment #2) > >URL: https://github.com/SecurityCentral/classification-banner > >Source0: > >https://github.com/SecurityCentral/classification-banner/archive/%{version}/%{name}-%{version}.tar.gz > You can shorten this by using %{URL} as part of Source0. Thanks! I didn't even think of that. Fixed. > > >%{__install} -d -m755 ... > >%{__install} -m644 ... > Macro forms of system executables should not be used. > https://fedoraproject.org/wiki/Packaging:Guidelines#Macros Thanks! I must have missed that in reading through the Guidelines. Fixed. Updated spec, SRPM, and ran builds. Spec URL: https://copr-be.cloud.fedoraproject.org/results/rga/classification-banner/epel-7-x86_64/00786861-classification-banner/classification-banner.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/rga/classification-banner/epel-7-x86_64/00786861-classification-banner/classification-banner-1.6.7-1.el7.src.rpm Koji Scratch Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=28973094 Copr Builds: https://copr.fedorainfracloud.org/coprs/rga/classification-banner/build/786861/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected]/message/XUHZ2BLBIQB4PXGXFU3PARPZ7JBAXIF7/
