Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=612581

--- Comment #18 from Miroslav Suchý <[email protected]> 2010-11-01 05:11:50 EDT 
---
> sql subpackage has /usr/share/rhn/server/__init__.py file which is a copy of
> file in /usr/lib/. This file is needed for some sub-packages to work I guess
> since some are placing files under /usr/share/rhn/server. Otherwise the dir
> wouldn't be recognized as python module. Am I correct? In that case please
> instead of having copy of the file, create a symlink from one to the other.
Correct. IMO this change will make Makefile more complicated and will make
maintenance harder, I do no think that saving 730 bytes will justify harder
maintenance.

> LICENSE files don't have to be included in every subpackage since they depend
> on each other.
I would rather have it there, if it is not problem.

> Use grep instead of egrep
addressed

> /usr/lib/python2.7/site-packages/spacewalk/wsgi and then populated
> /usr/share/rhn/wsgi/. I assume this is a mistake?
addressed

Updated SPEC:
http://miroslav.suchy.cz/fedora/spacewalk-backend/spacewalk-backend.spec
Updated SRPM:
http://miroslav.suchy.cz/fedora/spacewalk-backend/spacewalk-backend-1.2.48-1.el6.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
[email protected]
https://admin.fedoraproject.org/mailman/listinfo/package-review

Reply via email to