https://bugzilla.redhat.com/show_bug.cgi?id=1635415



--- Comment #2 from Robert-AndrĂ© Mauchin <[email protected]> ---
Thanks for the review!


1. /usr/share/color-schemes is not owned by this package, nor by any package
   that it Requires.

Now owned by Plasma desktop

2. Can the files under /usr/share/Kvantum go into a noarch subpackage?  That
   is, can the arch-specific package contain only %{_bindir}/kvantum* and
   %{_libdir}/qt5/plugins/styles/libkvantum.so?

Split into a data subpackage.

3. I'm not sure if that desktop file should be changed to use X-LXQt instead
   of LXQt.  It might be good to query somebody who can say definitively.

Patched into X-LXQt.


Spec URL: https://eclipseo.fedorapeople.org/kvantum.spec
SRPM URL: https://eclipseo.fedorapeople.org/kvantum-0.10.8-1.fc30.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to