https://bugzilla.redhat.com/show_bug.cgi?id=1636169
Kalev Lember <klem...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #2 from Kalev Lember <klem...@redhat.com> ---
Fedora review libxmlb-0.1.0-1.fc29.src.rpm 2018-10-04
$ rpmlint libxmlb-0.1.0-1.fc29.src.rpm \
libxmlb \
libxmlb-devel
libxmlb.src: W: spelling-error %description -l en_US deduplicated ->
reduplicated, duplicated, quadruplicated
libxmlb.src: W: spelling-error %description -l en_US mmap -> map, m map, mamma
libxmlb.x86_64: W: spelling-error %description -l en_US deduplicated ->
reduplicated, duplicated, quadruplicated
libxmlb.x86_64: W: spelling-error %description -l en_US mmap -> map, m map,
mamma
3 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ OK
! needs attention
+ rpmlint warnings are harmless and can be ignored
+ The package is named according to Fedora packaging guidelines
+ The spec file name matches the base package name.
+ The package meets the Packaging Guidelines
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The license text (LICENSE) is included in %license
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match the sources in the srpm
SHA512 (libxmlb-0.1.0.tar.xz) =
d09e4ac822fee6c2509f2d667e404ad7c959c1fb87b5676776d3a8255087b80814a6b29107432616f3dce76f10c1b0117e406c9959da06dbba4d8e9a677d88d0
SHA512 (Download/libxmlb-0.1.0.tar.xz) =
d09e4ac822fee6c2509f2d667e404ad7c959c1fb87b5676776d3a8255087b80814a6b29107432616f3dce76f10c1b0117e406c9959da06dbba4d8e9a677d88d0
+ Package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a locale handling
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
! Package doesn't own all the directories it creates:
%{_libdir}/girepository-1.0 and %{_datadir}/gir-1.0 and
%{_datadir}/gtk-doc/html and %{_datadir}/gtk-doc are unowned
+ No duplicate files in %files
+ Permissions are properly set
+ Consistent use of macros
+ The package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect the runtime of application
n/a Static libraries should be in -static
+ Development files should be in -devel
+ -devel must require the fully versioned base
+ Packages should not contain libtool .la files
n/a Proper .desktop file handling
+ Doesn't own files or directories already owned by other packages
+ Filenames are valid UTF-8
Looks nice and clean. Just a small nit about directory ownership:
The package creates %{_libdir}/girepository-1.0 and %{_datadir}/gir-1.0 and
%{_datadir}/gtk-doc/html and %{_datadir}/gtk-doc directories, but they aren't
listed in the spec file so they don't get removed when uninstalling the
package.
Can you add:
%dir %{_libdir}/girepository-1.0
%dir %{_datadir}/gir-1.0
%dir %{_datadir}/gtk-doc
%dir %{_datadir}/gtk-doc/html
... in the right spots in the spec file please?
Beyond that, looks good to me!
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
