https://bugzilla.redhat.com/show_bug.cgi?id=1544239



--- Comment #3 from Robert-AndrĂ© Mauchin <[email protected]> ---
I am sorry I have forgotten this Review.

 - Please use:

%global ver_patch 4

   for the latest stable release. Otherwise the Source0 is 404.

 - The new archive root folder is just named src/ Thus:

%setup -q -n src

 - You'll need to coordinate with unison227 for this:

# Is this package the unisonNNN package with the highest ${ver_compat}
# available in this Fedora branch/release? If so, we provide unison.
%global provide_unison 1

   Also try to bring Richard W.M. Jones (rjones) as a comaintainer.

 - The package fails to build:

BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 25, characters
16-33:
BUILDSTDERR: Warning 3: deprecated: Stdlib.String.unsafe_set
BUILDSTDERR: File "/builddir/build/BUILD/src/unicode.ml", line 822, characters
20-21:
BUILDSTDERR: Error: This expression has type string but an expression was
expected of type
BUILDSTDERR:          bytes
BUILDSTDERR: make: *** [Makefile.OCaml:435: unicode.cmx] Error 2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to