https://bugzilla.redhat.com/show_bug.cgi?id=1611606

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Robert-André Mauchin <[email protected]> ---
 - Mostly the same remarks as the previous bug

 - Do not depend on python-X package. Python 2 is deprecated in Fedora, now Py3
only.

 - Source0: must be a URL. Also you should ask upstream to do proper release.

 - %{__python} setup.py build → %py3_build

 - %{__python} setup.py install --single-version-externally-managed -O1
--root=$RPM_BUILD_ROOT → %py3_install

 - If you install systemd files you must require:

%{?systemd_requires}
BuildRequires: systemd

 - Please explain why you are moving and linking file in post and preun

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to