https://bugzilla.redhat.com/show_bug.cgi?id=1639000

Henrik Boeving <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]



--- Comment #1 from Henrik Boeving <[email protected]> ---
Doing an unofficial review!!

Two things I noticed:

Your Spec file appears to provide a python2 and python3 package, as you can
read here:
https://fedoraproject.org/wiki/Packaging:Python#Python_Version_Support new
software must not be packaged for python2 anymore.

I am not exactly sure about the PyYAML requirement in line 50 as this section
https://fedoraproject.org/wiki/Packaging:Python#Dependencies says your
dependencies must have python3- at the beginning.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to