https://bugzilla.redhat.com/show_bug.cgi?id=1636757



--- Comment #3 from Tomas Mraz <[email protected]> ---
Issues so far:

- "Uses parallel make %{?_smp_mflags} macro" - you just need to replace 'make'
call in %build with '%make_build'

- W: setup-not-quiet - just add '-q' option to %setup

- unversioned so-files - this is OK as this is a plug-in and not a general
purpose library

- version & release - the version & release does not conform to the:
https://fedoraproject.org/wiki/Packaging:Versioning (the version should not
contain the git snapshot tag - it should be placed into the Release. And there
is also missing the dist tag in the Release.

- license - this is in general OK, but I would recommend upstream to add the
OpenSSL License file to the git and released tarballs so it could be included
in the package (do not do that downstream)

- Please add Requires: %{name}%{?_isa} = %{version}-%{release} to the gostsum
subpackage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to