https://bugzilla.redhat.com/show_bug.cgi?id=1647689

Jitka Plesnikova <jples...@redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <jples...@redhat.com> ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
TODO: perl(ExtUtils::MakeMaker) can be removed from BR, because Makefile.PL
      is not used.

$ rpm -qp --requires perl-Template-Multilingual-1.00-1.fc30.noarch.rpm | sort |
uniq -c
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(strict)
      1 perl(Template)
      1 perl(Template::Multilingual::Parser)
      1 perl(Template::Parser)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Template-Multilingual-1.00-1.fc30.noarch.rpm | sort |
uniq -c
      1 perl(Template::Multilingual) = 1.00
      1 perl-Template-Multilingual = 1.00-1.fc30
      1 perl(Template::Multilingual::Parser) = 1.00
Binary provides are Ok.

$ rpmlint ./perl-Template-Multilingual*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' item.

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org

Reply via email to