https://bugzilla.redhat.com/show_bug.cgi?id=1646579

Robert-André Mauchin <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review+



--- Comment #1 from Robert-André Mauchin <[email protected]> ---
URL and Source addresses are Ok.
Source archive (SHA-256:
d3f6a608b85e09a8080a67a9933837aae6f2cd0e8ee39df3380123dc5e3de912) is original.
Ok.
Summary verified from lib/Net/IMAP/Client.pm. Ok.
Description verified from lib/Net/IMAP/Client.pm. Ok.
License verified from lib/Net/IMAP/Client.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

All tests pass. Ok.

$ rpmlint perl-Net-IMAP-Client-0.9505-1.fc30.src.rpm
review-perl-Net-IMAP-Client/results/perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm
review-perl-Net-IMAP-Client/results/perl-Net-IMAP-Client-0.9505-1.fc30.src.rpm  
3 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpm -q -lv -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm 
drwxr-xr-x    2 root    root                        0 nov.  8 11:51
/usr/share/doc/perl-Net-IMAP-Client
-rw-r--r--    1 root    root                     3681 janv. 18  2014
/usr/share/doc/perl-Net-IMAP-Client/Changes
-rw-r--r--    1 root    root                     1104 juil. 18  2014
/usr/share/doc/perl-Net-IMAP-Client/META.json
-rw-r--r--    1 root    root                      910 déc.  3  2008
/usr/share/doc/perl-Net-IMAP-Client/README
-r--r--r--    1 root    root                    12636 nov.  8 11:51
/usr/share/man/man3/Net::IMAP::Client.3pm.gz
-r--r--r--    1 root    root                     2435 nov.  8 11:51
/usr/share/man/man3/Net::IMAP::Client::MsgAddress.3pm.gz
-r--r--r--    1 root    root                     5001 nov.  8 11:51
/usr/share/man/man3/Net::IMAP::Client::MsgSummary.3pm.gz
drwxr-xr-x    2 root    root                        0 nov.  8 11:51
/usr/share/perl5/vendor_perl/Net
drwxr-xr-x    2 root    root                        0 nov.  8 11:51
/usr/share/perl5/vendor_perl/Net/IMAP
drwxr-xr-x    2 root    root                        0 nov.  8 11:51
/usr/share/perl5/vendor_perl/Net/IMAP/Client
-r--r--r--    1 root    root                    60101 juil. 18  2014
/usr/share/perl5/vendor_perl/Net/IMAP/Client.pm
-r--r--r--    1 root    root                     3454 déc.  3  2008
/usr/share/perl5/vendor_perl/Net/IMAP/Client/MsgAddress.pm
-r--r--r--    1 root    root                    15241 déc. 21  2010
/usr/share/perl5/vendor_perl/Net/IMAP/Client/MsgSummary.pm
File permissions and layout are Ok.

$ rpm -q --requires -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm | sort -f
| uniq -c
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(bytes)
      1 perl(Encode)
      1 perl(IO::Socket::INET)
      1 perl(IO::Socket::SSL)
      1 perl(List::MoreUtils)
      1 perl(List::Util)
      1 perl(Net::IMAP::Client::MsgAddress)
      1 perl(Net::IMAP::Client::MsgSummary)
      1 perl(overload)
      1 perl(Socket)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

⇒ Add BR for vars, strict, warnings, Socket, overload.

$ rpm -q --provides -p perl-Net-IMAP-Client-0.9505-1.fc30.noarch.rpm 
perl(Net::IMAP::Client) = 0.9505
perl(Net::IMAP::Client::MsgAddress)
perl(Net::IMAP::Client::MsgSummary)
perl-Net-IMAP-Client = 0.9505-1.fc30
Binary provides are Ok.



Package builds in Koji
(https://koji.fedoraproject.org/koji/taskinfo?taskID=30735927).
Ok

The package is in line with Fedora and Perl packaging guidelines.

Resolution: Package approved. Please fix the aforementioned issue before
import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to