https://bugzilla.redhat.com/show_bug.cgi?id=1649750
Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
CC| |zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org |zbys...@in.waw.pl
Flags| |fedora-review+
--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> ---
> BuildRequires: gcc gcc-c++
One-per-line please.
> export PYTHONPATH=$RPM_BUILD_ROOT/%{python2_sitearch}
I think %{buildroot} is nowadays considered nicer, but this is acceptable of
course.
+ package name is OK
+ latest version
+ license is acceptable for Fedora (MIT)
+ licencse is specified correctly
+ builds and installs OK
+ fedora-review is happy
+ R/BR/P look OK
Package is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
