https://bugzilla.redhat.com/show_bug.cgi?id=1649930

Carl George <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]
           Assignee|[email protected]    |[email protected]
              Flags|                            |fedora-review?



--- Comment #1 from Carl George <[email protected]> ---
Hello Robert!  I'll take a stab at reviewing this.  Please bear with me as I'm
still fairly new to golang library packaging, and feel free to push back on
anything I misunderstand.

The spec file name doesn't match the Name (golang-gopkg-square-jose vs
golang-gopkg-square-jose-2) [0].

The code includes a CLI utility [1].  I think this should either be built and
included, or have the source excluded from being installed in devel
(`%goinstall -t jose-util`).

[0]: https://fedoraproject.org/wiki/Packaging:Guidelines#Spec_File_Naming
[1]: https://github.com/square/go-jose/tree/v2.1.9/jose-util

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to