Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=523034 Toshio Ernie Kuratomi <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #8 from Toshio Ernie Kuratomi <[email protected]> 2010-11-04 10:14:36 EDT --- NEEDSWORK Good: * Named according to the naming guidelines (there's an underscore in all the upstream references to this name.) * license is BSD which is approved * spec file is readable * Source matches upstream * No locale files * No shared libraries * Not relocatable * No file listed multiple times * Permissions set properly * Package consistently uses macros * Code not content * Nothing in doc affects runtime * Not a GUI application * Does not bundle libraries in the built rpm but see below * filenames are valid utf8 * Does not own files owned by other packages * Owns all directories it creates Needswork: * Does not build in koji. The build looks for the setuptools_darcs package. This does not appear to be needed (only for creating sdists, not for the built package that we're doing so you can remove the line from the setup.py that adds this to requires. * setuptools_darcs code is present in the tarball. However, it is not being used in the build. The FPC is looking at new guidelines that say to remove such code (to make sure that it isn't being used in the build) so be ready for that potential guideline change. https://fedoraproject.org/wiki/PackagingDrafts/Treatment_Of_Bundled_Libraries Rpmlint: srpm and binary rpm share these warnings: python-setuptools_trial.src: W: spelling-error %description -l en_US Setuptools -> Setup tools, Setup-tools, Setups python-setuptools_trial.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging python-setuptools_trial.src: W: spelling-error %description -l en_US pyunit -> pyuria, punitive, impunity These are all common words in computer jargon or proper names so these are false positives. Fix the building problems and I'll give it one more look. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
