Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=529485 Jason Tibbitts <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #6 from Jason Tibbitts <[email protected]> 2010-11-04 12:34:21 EDT --- FYI, you don't need %clean at all these days. (F12 was the last Fedora release that needed it, and F12 is closed to new packages, so....) Unfortunately manipulation of %buildroot in %build is a guideline violation. rpmlint complains about it: qjoypad.src:35: W: rpm-buildroot-usage %build test -d $RPM_BUILD_ROOT || mkdir -p $RPM_BUILD_ROOT qjoypad.src:38: W: rpm-buildroot-usage %build ./config --prefix=%{_prefix} --install-dir=$RPM_BUILD_ROOT I believe it suffices to simply call the config script twice; once in %build without --install-dir and again in %install with --install-dir. This seems to result in an identical package. I installed and ran the package and it seems to work but I have no joypads (nor can I understand how anyone uses those uncomfortable things). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
