https://bugzilla.redhat.com/show_bug.cgi?id=1654881
Robert-André Mauchin <zebo...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebo...@gmail.com
--- Comment #1 from Robert-André Mauchin <zebo...@gmail.com> ---
- %defattr(-,root,root,-): This is not needed
- I don't understand the point of:
%dir %attr(755,root,root) %{gopath}/src/%{goipath}
%{gopath}/src/%{goipath}/*.go
%{gopath}/src/%{goipath}/pdfpasswd/*.go
All the files should already be specified in devel.file-list and thus do not
need to be specified manually.
- Why is there a trailing "toolchain." in the common description?
- Upstream provides releases: https://github.com/rsc/pdf/releases
You should use them:
%global goipath rsc.io/pdf
%global forgeurl https://github.com/rsc/pdf
Version: 0.1.1
%global common_description %{expand:
PDF reader implemented in Go.}
%gometa
Name: %{goname}
Release: 1%{?dist}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
