Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=645761 --- Comment #4 from Gianluca Sforna <[email protected]> 2010-11-04 18:51:16 EDT --- Ok. This is mosty in a good shape. please fix these rpmlint complaints and I think I can approve it: django-threadedcomments.noarch: W: summary-not-capitalized C a simple yet flexible threaded commenting system for Django django-threadedcomments.noarch: E: description-line-too-long C django-threadedcomments is a simple yet flexible threaded commenting system for Django. django-threadedcomments.noarch: W: incoherent-version-in-changelog 1.1.4-1 ['0.5.3-1.fc14', '0.5.3-1'] django-threadedcomments.noarch: W: hidden-file-or-dir /usr/share/doc/django-threadedcomments-0.5.3/docs/._pinax.txt Always remember to run rpmlint both on source and binary packages, reviewers are going to do it anyway and ask you to fix warning/errors It's also easier for the reviewer if you always increment the release number at each iteration, e.g. you sould make a 0.5.3-2, adding a changelog line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list [email protected] https://admin.fedoraproject.org/mailman/listinfo/package-review
