https://bugzilla.redhat.com/show_bug.cgi?id=1656533
Jitka Plesnikova <jples...@redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Jitka Plesnikova <jples...@redhat.com> ---
> FIX: License should be '(GPL+ or Artistic) and Public Domain', because
> files COPYRIGHT and CREDITS have license Public Domain,
> See Types-DateTime-0.002/COPYRIGHT line 13-17.
> FIX: Please update URL to use link to metacpan.org
> https://metacpan.org/release/Types-DateTime/
-License: GPL+ or Artistic
-URL: http://search.cpan.org/dist/Types-DateTime/
+License: (GPL+ or Artistic) and Public Domain
+URL: https://metacpan.org/release/Types-DateTime/
Ok.
> BuildRequires
> FIX: Please add following missing build-requires:
> - coreutils - spec file: line 34
> - findutils - spec file: line 34
> - make - spec file: line 32
> - perl-generators
> - perl-interpreter - spec file: line 28
> - perl(Moose) >= 2.06 - t/02mxtdt.t:31
> - perl(Moose::Util::TypeConstraints) - t/02mxtdt.t:26
> - perl(strict) - Makefile.PL:1, lib/Types/DateTime.pm:2
> - perl(Type::Library) - lib/Types/DateTime.pm:17
> - perl(Type::Utils) - lib/Types/DateTime.pm:22
> - perl(Type::Standard) - lib/Types/DateTime.pm:21
> - perl(warnings) - lib/Types/DateTime.pm:3
> - optional - perl(Locale::Maketext) - t/02mxtdt.t:128
All BRs were added
$ rpm -qp --requires perl-Types-DateTime-0.002-2.fc30.noarch.rpm | sort | uniq
-c
1 perl(:MODULE_COMPAT_5.28.1)
1 perl(:VERSION) >= 5.8.0
1 perl(DateTime)
1 perl(DateTime::Duration)
1 perl(DateTime::Locale)
1 perl(DateTime::TimeZone)
1 perl(Module::Runtime)
1 perl(Type::Library)
1 perl(Type::Utils)
1 perl(Types::Standard)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are ok
$ rpm -qp --provides perl-Types-DateTime-0.002-2.fc30.noarch.rpm | sort | uniq
-c
1 perl(Types::DateTime) = 0.002
1 perl-Types-DateTime = 0.002-2.fc30
Binary provides are ok
The package looks good now.
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/package-review@lists.fedoraproject.org
