https://bugzilla.redhat.com/show_bug.cgi?id=1657346

Jitka Plesnikova <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #1 from Jitka Plesnikova <[email protected]> ---
Source file is ok
Summary is ok
License is ok
Description is ok

FIX: Please replace URL link by
     https://metacpan.org/release/Net-OpenID-Common
     and Source0 by
    
https://cpan.metacpan.org/authors/id/W/WR/WROG/Net-OpenID-Common-%{version}.tar.gz

All tests passed

BuildRequires
FIX: Please add build-requires 
     - perl(utf8) - t/05-eq.t:5
     - perl-interpreter, make, findutils, coreutils - used in spec file

$ rpm -qp --requires perl-Net-OpenID-Common-1.20-1.fc30.noarch.rpm | sort |
uniq -c
      1 perl(base)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Crypt::DH::GMP)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(fields)
      1 perl(HTML::Parser)
      1 perl(HTTP::Headers::Util)
      1 perl(HTTP::Message) >= 5.814
      1 perl(HTTP::Request)
      1 perl(HTTP::Status)
      1 perl(Math::BigInt)
      1 perl(MIME::Base64)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Net::OpenID::Common)
      1 perl(Net::OpenID::Extension)
      1 perl(Net::OpenID::ExtensionMessage)
      1 perl(Net::OpenID::URIFetch)
      1 perl(Net::OpenID::Yadis::Service)
      1 perl(strict)
      1 perl(Time::Local)
      1 perl(URI::Escape)
      1 perl(warnings)
      1 perl(XML::Simple)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-OpenID-Common-1.20-1.fc30.noarch.rpm | sort |
uniq -c
      1 perl(Net::OpenID::Common) = 1.20
      1 perl-Net-OpenID-Common = 1.20-1.fc30
      1 perl(Net::OpenID::Extension) = 1.20
      1 perl(Net::OpenID::ExtensionMessage) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration::Request) = 1.20
      1 perl(Net::OpenID::Extension::SimpleRegistration::Response) = 1.20
      1 perl(Net::OpenID::IndirectMessage) = 1.20
      1 perl(Net::OpenID::URIFetch) = 1.20
      1 perl(Net::OpenID::URIFetch::Response) = 1.20
      1 perl(Net::OpenID::Yadis) = 1.20
      1 perl(Net::OpenID::Yadis::Service) = 1.20
      1 perl(OpenID::util) = 1.20
Binary provides are Ok.

$ rpmlint ./perl-Net-OpenID-Common*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct all 'FIX' issues.

Otherwise, the package looks good. 
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]

Reply via email to